Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498

Hin-Tak Leung hintak_leung at yahoo.co.uk
Tue Apr 15 19:41:52 CDT 2008


--- On Tue, 15/4/08, Juan Lang <juan.lang at gmail.com> wrote:

> From: Juan Lang <juan.lang at gmail.com>
> Subject: Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
> To: "Tomasz Jezierski - Tefnet" <developers at tefnet.pl>
> Cc: "Wine Developers List" <wine-devel at winehq.org>
> Date: Tuesday, 15 April, 2008, 3:14 PM
> >  Have you tried patch without this "if"? In
> my case it crashes without it
> >  when I try to open chm from bug #12498... i don't
> know if strdupW can
> >  dup NULL as well as null?
> 
> Aaaah...  Sorry, my mistake, I missed this declaration:
>         static const WCHAR null[] = {0};
> That solves that mystery.
> 
> In that case, one fix per patch, please.  This fix and the
> other are
> unrelated:  one fixes a crash, the other deals with a
> missing #STRINGS
> stream.  Thanks,
> --Juan

Hmm, sorry, it is probably not a good idea to name a variable "null" - 
it is just a little confusing. Maybe W_Null or even Wchar_Null or
to make it more obvious that it is a programmer-defined variable? 


      ___________________________________________________________ 
Yahoo! For Good helps you make a difference  

http://uk.promotions.yahoo.com/forgood/



More information about the wine-devel mailing list