cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."

Reece Dunn msclrhd at googlemail.com
Sat Apr 26 01:17:50 CDT 2008


2008/4/26 James Hawkins <truiken at gmail.com>:
>
> On Sat, Apr 26, 2008 at 1:03 AM, Reece Dunn <msclrhd at googlemail.com> wrote:
>  > 2008/4/26 James Hawkins <jhawkins at codeweavers.com>:
>  >
>  > > Hi,
>  >  >
>  >  >  The test was incorrect and failed on all platforms.  Vitaly, please
>  >  >  ask someone to test your patches on a real windows system in the
>  >  >  future if you don't have access to one.
>  >
>  >  Wouldn't it be better to actually fix the test case than revert it all together?
>  >
>
>  Have you actually read the patch or the changelog for that matter?

I misread the "Revert ..." part to mean a full revert of the original patch.

Sorry for the noise.
- Reece



More information about the wine-devel mailing list