ddraw: Remove a test that fails in VMs
Reece Dunn
msclrhd at googlemail.com
Sat Apr 26 01:20:03 CDT 2008
2008/4/26 James Hawkins <truiken at gmail.com>:
>
> On Sat, Apr 26, 2008 at 1:11 AM, Reece Dunn <msclrhd at googlemail.com> wrote:
> > Wouldn't it be better to move the ok line to directly after the
> > IDirect3D7_CreateDevice call? That way, on VM machines the test will
> > not get run and on non-VM machines it will, as it is a valid test in
> > that case.
>
> No, the test will still be run in all cases, VM or not, and will fail
> in VMs. The function just sets up the direct3d device object for
> other tests; there's no point in an ok test in this function,
> especially when it doesn't pass for all systems.
Ok.
- Reece
More information about the wine-devel
mailing list