Dan Kegel : winecfg: Restrict dpi slider to sane values.

[Vitaliy Margolen]

Austin English wrote:
> On 4/26/08, *Lei Zhang* <thestig at google.com <mailto:thestig at google.com>> 
> wrote:
> 
>     On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <thestig at google.com
>     <mailto:thestig at google.com>> wrote:
>      >
>      > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard
>     <julliard at winehq.org <mailto:julliard at winehq.org>> wrote:
>      >  > Module: wine
>      >  >  Branch: master
>      >  >  Commit: faaccca59be08be547ec4e1948b6306eff3808a2
>      >  >  URL:    http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2
>      >  >
>      >  >  Author: Dan Kegel <dank at kegel.com <mailto:dank at kegel.com>>
>      >  >  Date:   Tue Apr 22 17:56:36 2008 -0700
>      >  >
>      >  >  winecfg: Restrict dpi slider to sane values.
>      >  >
>      >  >  ---
>      >  >
>      >  >   programs/winecfg/x11drvdlg.c |    4 ++--
>      >  >   1 files changed, 2 insertions(+), 2 deletions(-)
>      >  >
>      >  >  diff --git a/programs/winecfg/x11drvdlg.c
>     b/programs/winecfg/x11drvdlg.c
>      >  >  index bfa6ec5..c0ec058 100644
>      >  >  --- a/programs/winecfg/x11drvdlg.c
>      >  >  +++ b/programs/winecfg/x11drvdlg.c
>      >  >  @@ -35,9 +35,9 @@
>      >  >
>      >  >   WINE_DEFAULT_DEBUG_CHANNEL(winecfg);
>      >  >
>      >  >  -#define RES_MAXLEN 5 /* the maximum number of characters in
>     a screen dimension. 5 digits should be plenty, what kind of crazy
>     person runs their screen >10,000 pixels across? */
>      >  >  +#define RES_MAXLEN 5 /* max number of digits in a screen
>     dimension. 5 digits should be plenty */
>      >  >   #define MINDPI 96
>      >  >  -#define MAXDPI 480
>      >  >  +#define MAXDPI 144     /* making this too high surprises and
>     hurts users */
>      >  >   #define DEFDPI 96
>      >  >
>      >  >   #define IDT_DPIEDIT 0x1234
>      >  >
>      >  >
>      >  >
>      >  >
>      >
>      >  Dan, this basically reverted commit
>      >  0110512904d9c646abef416819a057c06d3f2c97, which bumped MAXDPI
>     from 160
>      >  to 480 because some users specifically requested the ability for
>      >  higher DPI settings.
>      >
>      >  I think we need to decide what we want and stop the tug-o-war.
>      >
> 
> 
>     Please see bug 9715.
> 
> 
> The change was specifically requested. A warning if someone sets it over 
> 150, or a small explanation in winecfg would be better IMHO.
> 
> 
> ------------------------------------------------------------------------
> 
> 
For anyone who wants more then 150 they can change that in the registry. 
Honestly I've yet to see a single device with such a high DPI!

And since by definition users will do everything to screw themselves up we 
have to make it hard enough so majority will just give up.

Vitaliy.