[1/11] ole32 : basic inprocess handler implentation

Detlef Riekenberg wine.dev at web.de
Sat Aug 9 06:57:31 CDT 2008


On Do, 2008-08-07 at 15:45 +0200, f.dorin at free.fr wrote:
> This patch modifies the Makefile.in file to include some new file to be compile

- You must use your real name

- Wine must compile after every Patch.
  You need to add the changes for Makefile.in, when you add a file

- Why do you need to use sed for winuser.h?
  When the input for widl is correct and the output of widl is wrong,
  then widl must be fixed instead.

- You forgot the License-Header in the new files. Wine is LGPL.
  -- quote --
  2.1 of the License, or (at your option) any later version.
  -- quote --

- The subject is not very precise. You should use the description,
  that is already in your Mail. Example for [4/11]:
  "Main core file for inprocess handler implementation"

- Some Patches are large, please try to split it.

- Some lines in your Patches are very long, please try to split them.

- Do not use C++ style comments

- Wine is using 4 Space for indention.
  The only exception is to stay with the indention of File,
  when you touch that File

- No Idea, if the change in 8/11 is acceptable, but you should a comment
  in the code, when you make such a change.

- A Hack, to workaround a bug in widl will not be accepted.
  Widl must be fixed instead.

- Unrelated to the fact, that the Hack in 10/11 will not be accepted,
  you must make sure, not add spaces at the end of a Line.

- When you change the imlementation, that fix a test, then both changes
  must be in the same Patch


Thanks for helping Wine


-- 
 
By by ... Detlef





More information about the wine-devel mailing list