[PATCH] AcceptEx Impelementation

Kai Blin kai.blin at gmail.com
Sun Aug 10 02:16:32 CDT 2008


Hi Scott,

I didn't see a reply to your AcceptEx patches yet, sorry if I missed it and 
you get this again. Please submit one patch per email only. 

I admittedly don't know much about the wineserver stuff, but I've noticed a 
couple of style issues in the winsock code:

The indentation common in socket.c is either a two-space indent or a 
four-space indent. Please don't add new code with an eight-space indent.

Also, the common convention for ifs is
if (cond)
{
and not
if(cond){

Apart from those minor nitpicks, the code looks good.

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080810/590c7ac7/attachment.pgp 


More information about the wine-devel mailing list