[1/11] ole32 : basic inprocess handler implentation

Rob Shearman robertshearman at gmail.com
Sun Aug 10 12:36:48 CDT 2008


Hi François,

I appreciate the work you've put into this and the other patches.
However, I have a few comments:

2008/8/7  <f.dorin at free.fr>:
> @@ -78,4 +83,11 @@ ole2nls.spec.o: ole2nls.spec version16.res
>  version16.res: version16.rc
>  	$(LDPATH) $(RC16) $(RC16FLAGS) -fo$@ $(SRCDIR)/version16.rc
>
> +objidl_p.c: ../../include/objidl.idl
> +	$(WIDL) -p ../../include/objidl.idl
> +
> +oleidl_p.c: ../../include/oleidl.idl
> +	$(WIDL) -p ../../include/oleidl.idl
> +	sed -i '14i#include "winuser.h"' oleidl_p.c
> +

Custom make rules, such as these, are discouraged as they are a pain
to maintain because they need to be changed all over the source tree
instead of just in Make.rules.in. In this case they should be
unnecessary as you can simply create IDL files in the ole32 directory
(c.f. dlls/oleaut32/oleaut32_oaidl.idl) that include each of these
(and in the second case, add the necessary include file).

Also, it's a moot point but I don't think "sed -i" is portable.

-- 
Rob Shearman


More information about the wine-devel mailing list