Patch formatting question: how picky should the robot be?

Vitaliy Margolen wine-devel at kievinfo.com
Mon Aug 11 21:16:02 CDT 2008


Dan Kegel wrote:
> On Mon, Aug 11, 2008 at 2:27 PM, Zachary Goldberg <zgold550 at gmail.com> wrote:
>> Are there factors in this decision other than Alexandre's convenience?
> 
> He's the main voice, but others might feel strongly one way
> or the other, too.
> 
> 
It's been the rule for a long time when we were using cvs - always diff from 
  the top of the tree.

Detecting git patch is pretty straight forward. With other patches, if you 
can't find referenced file starting from the top of the tree - generate 
warning and drop the patch.

Vitaliy.



More information about the wine-devel mailing list