[advapi32] - Add stub for ConvertToAutoInheritPrivateObjectSecurity

Vijay Kiran Kamuju infyquest at gmail.com
Tue Aug 12 10:30:20 CDT 2008


On Mon, Aug 11, 2008 at 11:59 PM, Dmitry Timoshkov
<dmitry at codeweavers.com> wrote:
> "Vijay Kiran Kamuju" <infyquest at gmail.com> wrote:
>
>> +BOOL WINAPI ConvertToAutoInheritPrivateObjectSecurity(
>> +        PSECURITY_DESCRIPTOR ParentDescriptor,
>> +        PSECURITY_DESCRIPTOR CreatorDescriptor,
>> +        PSECURITY_DESCRIPTOR* NewDescriptor,
>> +        GUID* ObjectType,
>> +        BOOL IsDirectoryObject,
>> +        PGENERIC_MAPPING GenericMapping )
>> +{
>> +    FIXME("%p %p %p %p %d %p - stub\n", ParentDescriptor,
>> CreatorDescriptor,
>> +          NewDescriptor, ObjectType, IsDirectoryObject, GenericMapping);
>> +
>> +    return FALSE;
>> +}
>
> It would be better to not copy variable names from MSDN/PSDK and come up
> with your own naming. Say, (parent, creator, new, type, is_directory,
> mapping)
> would work.
I just used the CreatePrivateObjectSecurity as an example, it used
MSDN/PSDK naming.
>
>> --- a/include/winbase.h
>> +++ b/include/winbase.h
>> @@ -1373,6 +1373,7 @@ WINBASEAPI HANDLE      WINAPI
>> CreateNamedPipeW(LPCWSTR,DWORD,DWORD,DWORD,DWORD,D
>>  #define                       CreateNamedPipe
>> WINELIB_NAME_AW(CreateNamedPipe)
>>  WINBASEAPI BOOL        WINAPI
>> CreatePipe(PHANDLE,PHANDLE,LPSECURITY_ATTRIBUTES,DWORD);
>>  WINADVAPI  BOOL        WINAPI
>> CreatePrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,BOOL,HANDLE,PGENERIC_MAPPING);
>> +WINADVAPI  BOOL        WINAPI
>> ConvertToAutoInheritPrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,GUID*,BOOL,PGENERIC_MAPPING);
>>  WINBASEAPI BOOL        WINAPI
>> CreateProcessA(LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION);
>>  WINBASEAPI BOOL        WINAPI
>> CreateProcessW(LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION);
>>  #define                       CreateProcess
>> WINELIB_NAME_AW(CreateProcess)
>
> Please keep the entries alphabetically sorted.
Ok.
I will send another version with the changes soon.
>
---
VJ



More information about the wine-devel mailing list