user32: test what FindWindow when window isn't found

Dmitry Timoshkov dmitry at codeweavers.com
Wed Aug 13 22:09:24 CDT 2008


"Austin English" <austinenglish at gmail.com> wrote:

> -    /* test FindWindow behavior */
> +    SetLastError(0xdeadbeef);
> +    HWND hWnd = FindWindow("SomeWindowThatDoesNotExist", NULL);
> +    if(hWnd) {
> +      printf("hWnd not NULL");
> +    }
> +    else {
> +
> +     todo_wine
> +     ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());
> +    }

Why did you remove the comment? Introducing 'hWnd' variable is not needed,
there is one already called 'found', besides declaring variables in the code
is not allowed in Wine. It would be much simpler to add the last error test
to 2 existing FindWindowExA calls instead of introducing something looking
as foreign code (in indentation, braces usage and spaces).

-- 
Dmitry.



More information about the wine-devel mailing list