Better reflect the current state of DrawIconEx

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Mon Aug 18 08:09:08 CDT 2008


You indirectly asked for review of your patches. The comments below
might be reasons your patch did not get accepted. Best way to handle
ignored patches is to look over the patch again, and if one does not see
something that can be improved, just ask on wine-devel or (even better)
the IRC channel whether anyone can see something wrong with that patch.

Am Montag, den 21.07.2008, 21:17 +0200 schrieb Markus Hitter:
> diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c
> index a1ba570..eca9bfb 100644
> --- a/dlls/user32/cursoricon.c
> +++ b/dlls/user32/cursoricon.c
> @@ -1979,7 +1979,9 @@ BOOL WINAPI DrawIconEx( HDC hdc, INT x0, INT  
> y0, HICON hIcon,
>       if (istep)
>           FIXME_(icon)("Ignoring istep=%d\n", istep);
>       if (flags & DI_COMPAT)
> -        FIXME_(icon)("Ignoring flag DI_COMPAT\n");
> +        FIXME_(icon)("DI_COMPAT flag unimplemented (before NT4.0)\n");
As this flag is ignored on newer windows versions, you might think about
removing that check altogether instead of just changing the message.

> +    if (flags & DI_NOMIRROR)
> +        FIXME_(icon)("DI_NOMIRROR flag unimplemented (XP or later)\n");
As a wine user, I don't care which windows versions implement this flag.
What I do care about is whether the program requested some functionality
from wine it can't handle. So I would just show a message that says
"DI_NOMIRROR flag unimplemented", and skip the version information.

Regards,
  Michael Karcher




More information about the wine-devel mailing list