Add TRACEs to NtCreateFile returns
wine at mkarcher.dialup.fu-berlin.de
Mon Aug 18 08:13:48 CDT 2008
Am Sonntag, den 20.07.2008, 22:42 +0200 schrieb Markus Hitter:
> Similar to NtReadFile and NtWriteFile, NtCreateFile should trace
> return values on request. Providing the file handle allows to map
> read/write requests to the corresponding file name.
Seems very sensible. Your implementation looks OK, except for me not
being sure whether status codes are usually printed decimal or
hexadecimal. Please check.
> Additionally, wrap a overly long line.
Please don't put a style change and a functionality change that are
independent into the same patch. Usual convention is to leave style of
code parts one does not touch alone. If you really feel like that line
should be changed, submit it as seperate patch.
More information about the wine-devel