Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list
truiken at gmail.com
Mon Aug 25 13:46:51 CDT 2008
On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <ken at codeweavers.com> wrote:
> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:
>> "Dan Kegel" <dank at kegel.com> writes:
>>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard
>>> <julliard at winehq.org> wrote:
>>>> patchwatcher should watch for replies on wine-devel, and
>>>> link the reply to the patch
>>> Yes. The other similar patchwatching systems I found do this,
>>> and ours should, too.
>>>> and mark the patch as needing further action on the submitter's
>>> Even if the message says "Great job!"?
>> Sure, that's not the usual case. In most cases when a patch gets a
>> it's because it will need changes. There could of course be a way
>> for a
>> submitter to mark the patch as still valid, but the first action
>> be to take the patch off the list of committable patches.
> Perhaps replies meant to approve of a patch could include a special
> textual directive to indicate that patchwatcher shouldn't block the
> patch. Something like:
> #patchwatcher approve
> Such a directive would only be recognized if it's alone on a line.
The usual positive reply is 'ACK'. I believe it would be simplest to
grep the reply message for ACK to see if a reply is positive.
More information about the wine-devel