Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list
James McKenzie
jjmckenzie51 at earthlink.net
Mon Aug 25 20:42:06 CDT 2008
Dan Kegel wrote:
> On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <kai.blin at gmail.com> wrote:
>
>>>> #patchwatcher approve
>>>>
>>>> Such a directive would only be recognized if it's alone on a line.
>>>>
>>> The usual positive reply is 'ACK'. I believe it would be simplest to
>>> grep the reply message for ACK to see if a reply is positive.
>>>
>> Dunno, I find myself replying to patches that fix bugs I worked on myself or
>> that were in my code with things like "good catch". I agree with Alexandre
>> that cases like that are seldom enough that we can probably ignore them.
>>
>
> Around where I work, LGTM (looks good to me) is the reply that
> denotes approval. And then there's the Apache convention of +1.
> Anyway, I'll recognize one or more of those if and when I get around
> to adding a wine-devel listener. Might be a couple weeks.
>
>
Dan:
Thank you for adding this.
James McKenzie
More information about the wine-devel
mailing list