shlwapi: [PATCH 3/4] Fix results for UrlApplyScheme
Dmitry Timoshkov
dmitry at codeweavers.com
Tue Aug 26 04:30:46 CDT 2008
"Detlef Riekenberg" <wine.dev at web.de> wrote:
> Subject: [PATCH 2/4] shlwapi: Fix results for UrlApplyScheme
This subject doesn't match the e-mail subject line, and may confuse things.
> in = HeapAlloc(GetProcessHeap(), 0,
> - (2*INTERNET_MAX_URL_LENGTH) * sizeof(WCHAR));
> + (2*INTERNET_MAX_URL_LENGTH) * sizeof(WCHAR));
> out = in + INTERNET_MAX_URL_LENGTH;
>
> - MultiByteToWideChar(0, 0, pszIn, -1, in, INTERNET_MAX_URL_LENGTH);
> + MultiByteToWideChar(CP_ACP, 0, pszIn, -1, in, INTERNET_MAX_URL_LENGTH);
It would simplify things to allocate the buffer on the stack, since the buffer
is small and its size is known.
> +/*************************************************************************
> + */
> +
> static HRESULT URL_GuessScheme(LPCWSTR pszIn, LPWSTR pszOut, LPDWORD pcchOut)
> {
It's a usual convention to not leave an empty line after the API/function
description comment, and adding an empty comment is not useful at all.
--
Dmitry.
More information about the wine-devel
mailing list