taskmgr [try 6] [1/2]: Converted some functions and variables to Unicode

Alexandre Julliard julliard at winehq.org
Wed Aug 27 05:21:02 CDT 2008


Vladimir Pankratov <scriptkid at mail.ru> writes:

> @@ -93,7 +100,7 @@
>      ULONG                            Idx, Idx2;
>      HANDLE                            hProcess;
>      HANDLE                            hProcessToken;
> -    TCHAR                            szTemp[MAX_PATH];
> +    WCHAR                            wszTemp[256];
>      DWORD                            dwSize;
>      SYSTEM_PERFORMANCE_INFORMATION    SysPerfInfo;
>      SYSTEM_TIME_INFORMATION            SysTimeInfo;
> @@ -290,22 +297,10 @@
>          if (hProcess) {
>              if (OpenProcessToken(hProcess, TOKEN_QUERY|TOKEN_DUPLICATE|TOKEN_IMPERSONATE, &hProcessToken)) {
>                  ImpersonateLoggedOnUser(hProcessToken);
> -                memset(szTemp, 0, sizeof(TCHAR[MAX_PATH]));
> +                memset(wszTemp, 0, sizeof(wszTemp)/sizeof(WCHAR));
>                  dwSize = MAX_PATH;

You are introducing at least two bugs here. Please don't change things
that don't need changing.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list