Recent msi/package tests failures

James Hawkins truiken at gmail.com
Sat Aug 30 15:47:59 CDT 2008


On Sat, Aug 30, 2008 at 3:17 PM, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
> James Hawkins wrote:
>>
>> On Wed, Aug 27, 2008 at 2:18 PM, Paul Vriens <paul.vriens.wine at gmail.com>
>> wrote:
>>>
>>> James Hawkins wrote:
>>>>
>>>> On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <adam at tpetaccia.com>
>>>> wrote:
>>>>>
>>>>> On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I was looking into the recent test failures for the msi/package tests
>>>>>> on
>>>>>> my
>>>>>> WinXP box.
>>>>>>
>>>>>> The reason for most of them was a stray MSITEST package that couldn't
>>>>>> be
>>>>>> removed
>>>>>> via the 'Add/Remove Programs' (had to remove stuff from the registry).
>>>>>>
>>>>>> Any one else seeing this? (Adam Petaccia's XP box has the same issue I
>>>>>> guess).
>>>>>>
>>>>> I can provide any details you need about the XP box, the first thing I
>>>>> can think of is that the user running the tests is an administrator.
>>>>>
>>>> That's not why the tests are failing.  The install tests are timing
>>>> out, and if the winetest executable kills the child process that it
>>>> believes is 'hung', then you're killing the installer process midway
>>>> through an install and thus leaving the system in a broken state.
>>>>
>>> So were back to fixing the timeouts.
>>>
>>> I double checked again and can't see any logging enabled (checked the
>>> registry keys your provided).
>>>
>>
>> Of course; there are tons of tests.  The timeout needs to be extended,
>> at least for install.c.
>>
> Hi,
>
> I just sent a few patches that fix the problem with the timeout on my
> machines.
>
> Do you think it's still worthwhile to disable logging by using
> MsiEnableLogA? When I now look in my temp folder I have a few hundred MSI
> log files. We could either disable logging or create 1 file ourselves and
> append everything to there (removing it afterwards maybe).
>

Logging to one file takes just as long as any other type of logging.
No logging should be happening.  No I don't think it's worth using
MsiEnableLog to disable loggin.  Logging is not enabled by default,
and to enable it you have to change some registry entries, which I
doubt anyone is doing.

-- 
James Hawkins



More information about the wine-devel mailing list