inetcomm: possible null pointer dereferences

Hans Leidekker hans at codeweavers.com
Fri Dec 5 03:00:38 CST 2008


On Thursday 04 December 2008 21:32:37 Gregor Schneider wrote:

> -    TRACE("(%s)\n", pszEmailFrom);
> -
>      if (!pszEmailFrom)
>         return E_INVALIDARG;
> 
> +    TRACE("(%s)\n", pszEmailFrom);
> +
> +    len = sizeof(szCommandFormat) - 2 /* "%s" */ + strlen(pszEmailFrom);
> +

Instead of moving the trace down you should use debugstr_a(), which handles
the NULL pointer for you.

 -Hans



More information about the wine-devel mailing list