Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.
Huw Davies
huw at codeweavers.com
Tue Dec 9 09:05:14 CST 2008
On Mon, Dec 08, 2008 at 01:44:41PM +0100, Alexandre Julliard wrote:
> Huw Davies <huw at codeweavers.com> writes:
>
> > Hi Alexandre,
> >
> > This wasn't what I intended my patch to do. The problem is that
> > Wine's ChoosePixelFormat() rets 0 on XServers without glX. The
> > win_skip results in a test failure. My patch was intended to mark
> > this as a todo_wine.
>
> We could have a todo_wine around the win_skip, though I'm not quite
> convinced that having the opengl32 test succeed without opengl support
> is the right thing to do.
Ok, I'll send in a patch with todo_wine and let you decide.
My feeling was that without opengl support we should skip the opengl32
tests, hence the skip in the original patch. The todo_wine was to
flag Wine's ChoosePixelFormat bug.
Huw.
--
huw at codeweavers.com
More information about the wine-devel
mailing list