winmm: Sign-compare warning fix (Resend)
mstefani at redhat.com
Fri Dec 12 04:29:06 CST 2008
Andrew Talbot wrote:
> On Fri Dec 12 0:58 , Michael Stefaniuc sent:
>> Andrew Talbot wrote:
>>> What is wrong with this patch, please?
>> If I may venture a guess: You have replaced a nice and concise for loop
>> into and ugly 4 line while loop.
> Ugly? Andrew Koenig and Barbara Moo show a similar construct in their book
> "Accelerated C++". ;)
Too bad that I'm not reading that book at the moment but
"The Practice of Programming" and that book disagrees with that ;)
> But how would you then fix the sign-compare violation, or would you just let this
> one go?
I had to look twice as the initial warning was in a for loop above:
Either leave it as is for now as the warning is bogus or at least add
the decrement directly to the while like this:
i = sizeof(MMDrvs) / sizeof(MMDrvs);
while (i-- > 0)
Though the later would still have to pass Alexandre's review.
More information about the wine-devel