d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error

Stefan Dösinger stefan at codeweavers.com
Tue Dec 23 07:00:51 CST 2008


Hi,

Please write a test for this. This behavior differs from function to
function unfortunately. Some functions do not set the value to NULL, and
some apps depend on this.

I think dlls/d3d9/tests/shader.c is a good place to put this test.

-----Original Message-----
> From: wine-patches-bounces at winehq.org [mailto:wine-patches-
> bounces at winehq.org] On Behalf Of Vincent Pelletier
> Sent: Monday, December 22, 2008 11:25 PM
> To: wine-patches
> Subject: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to
> NULL on error
> 
> When IWineD3DDevice_GetVertexShader fails, set *ppShader to NULL.
> 
> This fixes "Black & White 2" here: it used to crash right when first
> level intro video ended, before seeing the level. With this patch I can
> play a bit (though there are some graphical glitches remaining, mouse
> it not so
> smooth...)
> 
> --
> Vincent Pelletier




More information about the wine-devel mailing list