[PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)
stefan at codeweavers.com
Thu Dec 25 05:08:37 CST 2008
Your wined3d_gl.h patch was applied, the others weren't
Sometimes too much discussion makes AJ wait on a patch too, to see how the
discussion turns out. If you resend your patches I'll just reply with an
"patch is ok" mail to avoid further confusion
> -----Original Message-----
> From: Nick Burns [mailto:adger44 at hotmail.com]
> Sent: Thursday, December 25, 2008 1:06 AM
> To: stefan at codeweavers.com; wine-devel at winehq.org
> Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer
> Thanks for the explanation -- I will email asking why soon -- and
> perhaps resubmit the other patch
> I have been looking at http://winehq.org/pipermail/wine-cvs to see what
> has been applied
> But source.winehq.org/git shows the diffs much nicer
> - Nick
> > From: stefan at codeweavers.com
> > To: adger44 at hotmail.com; wine-devel at winehq.org
> > Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer
> > Date: Wed, 24 Dec 2008 15:48:24 +0100
> >> Thanks for reviewing my patch (it sure makes the SHOGO menu much
> >> BTW do you know if I need to resubmit my other SHOGO patch ([PATCH]
> >> ddraw surface version setting)?
> > Yes, I recommend to do that. It is likely that it was lost or didn't
> > any longer after the 3 days it waited in moderation.
> > You can see on source.winehq.org/git or with 'git log origin' if your
> > was applied. If it wasn't, it is best to send a mail to wine-devel
> > why, or ask Alexandre(nick 'julliard') on #winehackers. Quite often
> > Alexandre sends a reply if he doesn't like the patch(or someone else
> > but not always.
> > Alexandre usually wants a confirmation from someone who knows the
> > the case of d3d Heri, Roderick or me) if a new contributor sends a
> > hence my "the patch is ok" mails.
> > I don't know if Alexandre will apply patches over the holidays, so if
> > patch is silently ignored it is best to resend it in a few days.
More information about the wine-devel