pdh[3:3]: remove unnecessary tests done inPdhLookupPerfNameByIndexW

[Dmitry Timoshkov]

"Jeff Latimer" <lats at yless4u.com.au> wrote:

>>> --- a/dlls/pdh/pdh_main.c
>>> +++ b/dlls/pdh/pdh_main.c
>>> @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( 
>>> LPCSTR machine, DWORD index, LPSTR
>>>
>>>     TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size);
>>>
>>> -    if (machine)
>>> -    {
>>> -        FIXME("remote machine not supported\n");
>>> -        return PDH_CSTATUS_NO_MACHINE;
>>> -    }
>>> -
>>>     if (!buffer || !size) return PDH_INVALID_ARGUMENT;
>>> -    if (!index) return ERROR_SUCCESS;
>>
>> Changelog mentions PdhLookupPerfNameByIndexW by the change is in 
>> PdhLookupPerfNameByIndexA.
>> Why are you removing the checks in one place by leave the same in 
>> other one? Why the tests
>> are unnecessary?
>>
> The parameters, bufferW and sizeW passed by PdhLookupPerfNameByIndexA to 
> PdhLookupPerfNameByIndexW are  local to PdhLookupPerfNameByIndexA.

That doesn't mean that PdhLookupPerfNameByIndexW can't be called directly.

> The 
> test is needed still in PdhLookupPerfNameByIndexA because the size and 
> buffer are not passed but still need to be checked.

That still doesn't answer my questions.

-- 
Dmitry.