Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.

Robert Shearman rob at codeweavers.com
Tue Feb 19 05:45:24 CST 2008


Alexandre Julliard wrote:
> Robert Shearman <rob at codeweavers.com> writes:
>
>   
>> The point is that all of the files need it. Only tools/widl/parser.l
>> needs to include unistd.h and it already does so manually.
>>     
>
> Then you should put the option in all the files. That sort of thing
> doesn't belong in the global make rules.

I disagree. The global make rules, among other things, should enforce 
policies whether this be telling the C compiler to error on certain 
non-portable constructs like declarations after statements or telling 
flex not to output code that includes headers that might not be present, 
like unistd.h.

However, I've sent a patch that turns the option on individually for 
each file so that you can choose which route to take.

-- 
Rob Shearman




More information about the wine-devel mailing list