comdlg32: Remove unneeded casts (Resend)

Robert Shearman rob at codeweavers.com
Wed Jan 2 17:16:45 CST 2008


Andrew Talbot wrote:
>            if (fodInfos->ofnInfos->Flags & OFN_ALLOWMULTISELECT)
>               size += 1;
>            /* return needed size in first two bytes of lpstrFile */
> -          *(WORD *)fodInfos->ofnInfos->lpstrFile = size;
> +          *fodInfos->ofnInfos->lpstrFile = size;
>            FILEDLG95_Clean(hwnd);
>            ret = EndDialog(hwnd, FALSE);
>            COMDLG32_SetCommDlgExtendedError(FNERR_BUFFERTOOSMALL);
> @@ -763,7 +763,7 @@ static BOOL PRINTDLG_SetUpPaperComboBoxW(HWND hDlg,
>      NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName,
>                                        fwCapability_Names, Names, dm);
>      NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName,
> -				      fwCapability_Words, (LPWSTR)Words, dm);
> +                                      fwCapability_Words, Words, dm);
>  
>      /* reset any current content in the combobox */
>      SendDlgItemMessageW(hDlg, nIDComboBox, CB_RESETCONTENT, 0, 0);
>   

I think these two casts should stay as LPWSTR is compatible with WORD * 
only by coincidence - one is intended to hold characters and the other 
numbers.

-- 
Rob Shearman




More information about the wine-devel mailing list