mshtml #4: Includes clean up. (fixed)
Alexandre Julliard
julliard at winehq.org
Fri Jan 4 05:05:51 CST 2008
Jacek Caban <jacek at codeweavers.com> writes:
> diff --git a/dlls/mshtml/install.c b/dlls/mshtml/install.c
> index 731af60..2437797 100644
> --- a/dlls/mshtml/install.c
> +++ b/dlls/mshtml/install.c
> @@ -18,33 +18,23 @@
>
> #include "config.h"
>
> -#include <stdarg.h>
> +#include "mshtml_private.h"
> +#include "resource.h"
> +
> #include <fcntl.h>
> #ifdef HAVE_UNISTD_H
> # include <unistd.h>
> #endif
It's not a good idea to include Unix headers after the Windows ones,
that can create trouble.
I have to admit I'm not a big fan of that sort of one include to rule
them all approach, I think it's better to have each file maintain
control over what it includes and in which order. The global
mshtml_private.h header should only include the stuff it itself depends
on, not every single header that any source file may want to use.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list