Implement IStream interface for msxml3 domdoc

Dmitry Timoshkov dmitry at codeweavers.com
Sat Jan 12 09:25:39 CST 2008


"Josef Reidinger" <josef.reidinger at seznam.cz> wrote:

> changelog:
> * implement IStream write for msxml domdoc

What are the tab settings in your editor? All white space in your
patches looks completely broken. Set tab size to 8 spaces, and try
to avoid tabs at all.

> +  if (!This->Stream){
> +   
> +  }

Why is the code above is needed?

> +static const IStreamVtbl xmldoc_IStream_VTable =
> +{
> +  xmldoc_IStream_QueryInterface,
> +  xmldoc_IStream_AddRef,
> +  xmldoc_IStream_Release,
> +    xmldoc_IStream_Read,
> +    xmldoc_IStream_Write,
> +    xmldoc_IStream_Seek,
> +    xmldoc_IStream_SetSize
> +/*    xmldoc_IStream_CopyTo,
> +    xmldoc_IStream_Commit,
> +    xmldoc_IStream_Revert,
> +    xmldoc_IStream_LockRegion,
> +    xmldoc_IStream_UnlockRegion,
> +    xmldoc_IStream_Stat,
> +    xmldoc_IStream_Clone*/
> +};

You can't provide a partial vtable.

> +  TRACE("1");

Remove all debugging craft before submitting the patch.

-- 
Dmitry.



More information about the wine-devel mailing list