[PATCH] Wine's ChangeDisplaySettingsEx is too strict

Dmitry Timoshkov dmitry at codeweavers.com
Sun Jan 20 03:51:14 CST 2008


"Jeff Latimer" <lats at yless4u.com.au> wrote:

> >      if ((devmode->dmFields & (DM_PELSWIDTH | DM_PELSHEIGHT)) != (DM_PELSWIDTH | DM_PELSHEIGHT))
> >      {
> >          WARN("devmode doesn't specify the resolution: %04x\n", devmode->dmFields);
> > -        return DISP_CHANGE_BADMODE;
> >      } 
> Is this warning still valid if this is valid Windows behaviour?

Yes it's still valid until there is a test case which shows that Windows
does something different in this case.

-- 
Dmitry.



More information about the wine-devel mailing list