dlls/d3d9/tests/visual.c -- address five compiler warnings (RESEND)

Gerald Pfeifer gerald at pfeifer.com
Fri Jan 25 06:30:26 CST 2008


On Mon, 14 Jan 2008, Alexandre Julliard wrote:
>> @@ -4348,12 +4349,12 @@ static void vshader_version_varying_test
>>         "vs_3_0 returned color 0x%08x, expected 0x00203366\n", color);
>>      color = getPixelColor(device, 160, 360);
>>      ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 &&
>> -       (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 &&
>> +                                             (color & 0x0000ff00) <= 0x00000000 &&
>>         (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068,
>>         "vs_1_1 returned color 0x%08x, expected 0x00808080\n", color);
>>      color = getPixelColor(device, 480, 360);
>>      ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 &&
>> -       (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 &&
>> +                                             (color & 0x0000ff00) <= 0x00000000 &&
>>         (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068,
>>         "vs_2_0 returned color 0x%08x, expected 0x00000000\n", color);
> 
> These tests don't make much sense, with or without your fix, plus the
> error messages don't match the tests. This needs more work.

It seems this was added with 2007-11-07 with the following log entry:
  
  Stefan Dösinger <stefan at codeweavers.com>
  wined3d: Shader Model 3.0 varying tests.

Stefan, any chance you could look into this at one point?

THanks,
Gerald


More information about the wine-devel mailing list