bug 14357: undefined edge padding in bitmaps annoys valgrind

James Hawkins truiken at gmail.com
Tue Jul 8 13:14:56 CDT 2008


On Tue, Jul 8, 2008 at 12:59 PM, John Reiser <jreiser at bitwagon.com> wrote:
> Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14357
> undefined edge padding in bitmaps annoys valgrind
>

+    memset(image->data, 0, image->bytes_per_line * height);  /* valgrind */

I don't think we should add comments like this.  The reason for fixing
it is because some logic could potentially depend on an undefined
value, which valgrind handily warns us about.

-- 
James Hawkins



More information about the wine-devel mailing list