user32: sizeof DDEPOKE and DDEDATA is six, which is probably not what is expected, so use offsetof instead.

Huw Davies huw at codeweavers.com
Tue Jul 8 13:18:20 CDT 2008


James Hawkins wrote:
> 2008/7/8 Huw Davies <huw at codeweavers.com>:
>> Fixes a todo_wine and a Valgrind warning.
> 
> @@ -699,10 +699,7 @@ static HDDEDATA CALLBACK
> server_ddeml_callback(UINT uType, UINT uFmt, HCONV hcon
> 
>          ptr = (LPSTR)DdeAccessData(hdata, &size);
>          ok(!lstrcmpA(ptr, "poke data\r\n"), "Expected 'poke
> data\\r\\n', got %s\n", ptr);
> -        todo_wine
> -        {
> -            ok(size == 14, "Expected 14, got %d\n", size);
> -        }
> +        ok(size == 12, "Expected 12, got %d\n", size);
>          DdeUnaccessData(hdata);
> 
>          size = DdeQueryStringA(server_pid, hsz2, str, MAX_PATH, CP_WINANSI);
> 
> You changed the value of the test.  Did you mean to do that?

Yes.  See 'size' in create_poke().

Huw.




More information about the wine-devel mailing list