[PATCH 1/2] user32: Add more tests for SetWindowPos.
Alexandre Julliard
julliard at winehq.org
Fri Jul 11 08:28:59 CDT 2008
"Lei Zhang" <thestig at google.com> writes:
> +static UINT sequence_contains(UINT msg)
> +{
> + static const struct message end_of_sequence = { 0, 0, 0, 0 };
> + const struct message *actual;
> + UINT num = 0;
> +
> + add_message(&end_of_sequence);
> + actual = sequence;
> +
> + while (actual->message)
> + {
> + if (actual->message == msg) num++;
> + actual++;
> + }
> + return num;
> +}
The fix looks good now, but you should really test the message sequences
instead of just counting a single message. We have already all the
necessary mechanisms for this.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list