Uninitialized memory reference in winefile

[Martin Fuchs]

Hello Dan,

if you change the following line 2711, I think the Valgrind message  
will disappear:


      /* no change? */
-    if (!memcmp(orgWidths, pane->widths, sizeof(orgWidths)))
+    if (!anyway && !memcmp(orgWidths, pane->widths, sizeof(orgWidths)))
        return FALSE;

Sorry - I could not yet verify it - please mail back it there other  
issues.

Regards,

    Martin


Am 17.07.2008 um 19:26 schrieb Dan Kegel:

> While valgrinding Picasa, I came across the following valgrind error
> in winefile.  (My daily valgrind runs only run the conformance
> suite, which is why I've never seen this before.)
> The lines involved seem unchanged since Martin Fuchs'
> winefile code was merged back in 2002.
>
> Conditional jump or move depends on uninitialised value(s)
>   at calc_widths (winefile.c:2711)
>   by create_tree_window (winefile.c:2974)
>   by InitChildWindow (winefile.c:2984)
>   by ChildWndProc (winefile.c:4259)
>   by ??? (library.h:136)
>   by call_window_proc (winproc.c:457)
>   by WINPROC_call_window (winproc.c:2198)
>   by call_window_proc (message.c:1610)
>   by send_message (message.c:2434)
>   by SendMessageW (message.c:2557)
>   by WIN_CreateWindowEx (win.c:1164)
>   by CreateWindowExW (win.c:1362)
>   by MDIClientWndProc_common (mdi.c:1140)
>   by MDIClientWndProcW (mdi.c:1307)
>   by ??? (library.h:136)
>   by call_window_proc (winproc.c:457)
>   by WINPROC_call_window (winproc.c:2198)
>   by call_window_proc (message.c:1610)
>   by send_message (message.c:2434)
>   by SendMessageW (message.c:2557)
>   by create_child_window (winefile.c:1789)
>   by show_frame (winefile.c:4839)
>   by winefile_main (winefile.c:4931)
>   by WinMain (winefile.c:4965)
>   by main (exe_main.c:48)
> Uninitialised value was created by a stack allocation
>   at calc_widths (winefile.c:2645)