[2 of 2] ole32: always return false when asked if NULL is the current clipboard

Rob Shearman robertshearman at gmail.com
Sat Jul 19 11:27:02 CDT 2008


2008/7/17 Vincent Povirk <vincent at codeweavers.com>:
> @@ -583,6 +583,9 @@ HRESULT WINAPI OleIsCurrentClipboard(IDataObject *pDataObject)
>    if (!theOleClipboard)
>      return E_OUTOFMEMORY;
>
> +  if (pDataObject == NULL)
> +    return S_FALSE;
> +

Functionally, the patch is good, but one small nit about the style -
the check before uses the !ptr style whereas the check that you
introduce uses the ptr == NULL style. It would be nice if the checks
had a consistent style.

-- 
Rob Shearman

P.S. Congratulations on your new job :-)



More information about the wine-devel mailing list