EverQuest2.exe and context.c

[Chris Ahrendt]

Stefan Dösinger wrote:
>> why not remove this  and go ahead and call ChoosePixelFormat?
>> If ChoosePixelFormat fails then we say we can't find  a suitable pixel
>> format? This removes one problem when EverQuest2.exe runs where I get
>> 2-3 calls to WineD3D_ChoosePixelFormat
> Roderick has written this code, and he is on vacation right now.
> 
> One of our rules is not to do any change to the code that happens to fix an
> app without doubt-free understanding of what the problem is. (Sometimes we
> have to make exceptions, e.g. with random graphics driver bugs)
> 
> As far as I understand it, findCompatible is set when an onscreen drawable
> is created(drawing to a window), and it is FALSE if a pbuffer is created(one
> form of offscreen rendering). pbuffers aren't created at device creation or
> reset time, so something seems odd that removing the !findCompatible fixes a
> startup crash(unless the app instantly tries to do offscreen rendering and
> you have offscreenRenderingMode = pbuffer)
> 
> The reason for not accepting compatible formats with pbuffers is(among
> others maybe) that rendering on a different format and then copying it to a
> texture can cause serious performance problems. So the !findCompatible in
> this code looks correct to me, but maybe the caller sets the flag
> incorrectly. Also it seems strange that this patch fixes a problem that is
> caused by recursive Reset() calls.
> 
> I sent a patch to make the pixel format check less picky(especially
> regarding AUX buffers). I lost your reply to it, and Alexandre didn't apply
> it yet, I think due to your unanswered concern about it. Does that patch fix
> the problem with the game?
> 
> The patch I mean is this:
> http://www.winehq.org/pipermail/wine-patches/2008-July/058282.html
> 
> 
Ok I did a clean install.. rebuilt wine from the base 1.1.1  code
put the above patch into the context.c and reran EverQuest2.exe
I put export WINEDEBUG=+d3d,+sed before running and am attaching the
trace. (If you need more just send me a message and I will retry it.
I still get the card does not have pixel shader error (and yes the card
has pixel shaders (its an ATI FIREGL5200)). I am attaching the log and 
the screenshot.

Chris


-------------- next part --------------
A non-text attachment was scrubbed...
Name: EQ2err.png
Type: image/png
Size: 497411 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080723/2f835caf/attachment-0001.png 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch_error.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20080723/2f835caf/attachment-0001.txt