[1/3] WineD3D: Use C bitfields to compact the ffp description (try 2)

Alexandre Julliard julliard at winehq.org
Wed Jul 30 06:53:53 CDT 2008


Stefan Dösinger <stefan at codeweavers.com> writes:

> @@ -1785,16 +1785,17 @@ void gen_ffp_op(IWineD3DStateBlockImpl *stateblock, struct ffp_settings *setting
>      };
>      unsigned int i;
>      DWORD ttff;
> +    DWORD cop, aop, carg0, carg1, carg2, aarg0, aarg1, aarg2;
>  
>      for(i = 0; i < GL_LIMITS(texture_stages); i++) {
>          IWineD3DBaseTextureImpl *texture;
>          if(stateblock->textureState[i][WINED3DTSS_COLOROP] == WINED3DTOP_DISABLE) {
>              settings->op[i].cop = WINED3DTOP_DISABLE;
>              settings->op[i].aop = WINED3DTOP_DISABLE;
> -            settings->op[i].carg0 = settings->op[i].carg1 = settings->op[i].carg2 = 0xffffffff;
> -            settings->op[i].aarg0 = settings->op[i].aarg1 = settings->op[i].aarg2 = 0xffffffff;
> +            settings->op[i].carg0 = settings->op[i].carg1 = settings->op[i].carg2 = -1;
> +            settings->op[i].aarg0 = settings->op[i].aarg1 = settings->op[i].aarg2 = -1;

It's not very clean to store -1 into unsigned variables, the previous
code was better IMO.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list