urlmon: Fix a test that fails on all platforms

Dmitry Timoshkov dmitry at codeweavers.com
Tue Jun 3 20:52:43 CDT 2008


"James Hawkins" <jhawkins at codeweavers.com> wrote:

> -        ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");
> +
> +        if(bindf & BINDF_ASYNCHRONOUS) {
> +            ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed here\n");
> +            IBindCtx_Release(bctx); /* actually destroy it */
> +        }
> +        else
> +            ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");

Wouldn't it be better to change it this way:

if(bindf & BINDF_ASYNCHRONOUS)
    ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed here\n");

ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");

-- 
Dmitry.



More information about the wine-devel mailing list