mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in aboutprotocol.

Dmitry Timoshkov dmitry at codeweavers.com
Fri Jun 6 21:47:39 CDT 2008


"Jacek Caban" <jacek at codeweavers.com> wrote:

>>          return E_NOTIMPL;
>> +    case QUERY_USES_HISTORYFOLDER:
>> +        FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n");
>>      default:
>>          return E_FAIL;
>>      }
>>
>> shouldn't there be a "return E_NOTIMPL" after the FIXME as we do with 
>> the others?
> 
> It doesn't really matter IMO, so I've made the patch no-op. This way 
> Wine will behave like IE6 until we will have proper IE7 implementation.

Then please add the explicit /* fall through */ comment indicating that
the behaviour is intentional, and not just an oversight.

-- 
Dmitry.



More information about the wine-devel mailing list