netapi32: Set the buffer to NULL in NetApiBufferFree

Kai Blin kai.blin at gmail.com
Thu Jun 26 12:56:37 CDT 2008


On Thursday 26 June 2008 19:51:41 Juan Lang wrote:
> So setting Buffer' to NULL has no impact on the HeapFree of Buffer''.
> The fact that this makes a Valgrind warning disappear still seems like
> a Valgrind bug.  If it were doing static analysis, I'd say it's gotten
> confused by aliasing.  Since it's doing dynamic analysis, I have to
> ask why that's causing the warning to go away.

I didn't test it. Thinking about this a bit more, you're obviously correct. I 
shouldn't write patches before 8am, I guess.

My fault, never mind. Alexandre suggested just killing the second 
NetApiBufferFree() call, so that's what I'm going to do.

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080626/ecf3c9cb/attachment.pgp 


More information about the wine-devel mailing list