richedit: Implemented EM_STOPGROUPTYPING, fixed undo grouping (with tests)

James McKenzie jjmckenzie51 at sprintpcs.com
Thu Jun 26 21:35:04 CDT 2008


Alex Villací­s Lasso wrote:
> Dylan Smith escribió:
>   
>> EM_STOPGROUPTYPING simply ends the undo coalescing transaction.  The
>> remarks for this message on MSDN explains what events stops group
>> typing, which led me to adding the delete key to the actions that stop
>> group typing.
>>
>> The tests that are included with this patch verify the correctness of
>> the changes.
>>
>> This patch depends on a previous patch I submitted, which has an email
>> subject "[6/44] richedit: Implemented undo coalescing to group typing
>> events", and was submitted on June 17.
>> ---
>>  dlls/riched20/editor.c       |   12 ++++++++++--
>>  dlls/riched20/tests/editor.c |   40 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 50 insertions(+), 2 deletions(-)
>>   
>>     
> This patch has the corresponding test. Could you please send a patch 
> (one or more) that would test the behaviors fixed by the previous 
> patches? This will make it more likely for AJ to accept the patches, and 
> will also prevent someone (such as myself) from accidentally breaking 
> fixed behavior with further changes.
>
>   
Alex:

You are talking about fixing things.  I was fixing EM_FONTRANGE before 
1.0 as it breaks several things.  Are you looking to pick this up as one 
of the things you are going to fix?

James McKenzie




More information about the wine-devel mailing list