Ok guys...

Reece Dunn msclrhd at googlemail.com
Thu Jun 26 16:11:40 CDT 2008


2008/6/26 Dan Kegel <dank at kegel.com>:
> Your subject line was confusing; what's this about?
>
> Your patches seem malformed, they come across with
> question marks for tabs, e.g.

They look fine on my googlemail account :), and it looks like they are
spaces, not tabs.

> --- context.c??? 2008-06-26 13:52:57.000000000 -0400
> +++ context.c.patch1??? 2008-06-26 15:19:15.000000000 -0400
> @@ -145,9 +145,7 @@ static int WineD3D_ChoosePixelFormat(IWi
> ?
> ???? DepthStencilFormat = WINED3DFMT_D24S8;
> ?
> -??? if(DepthStencilFormat) {
> -??????? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);
> -??? }
> +??? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);

Is this an encoding issue due to a non-0x20 space being used (e.g. the
non-breaking whitespace 0xA0)?

> If you expect the patches to be applied, they
> need to go to wine-patches, not wine-devel.

As has been said before, the developer is trying to get feedback
before sending the patches there.

- Reece



More information about the wine-devel mailing list