richedit: Implemented EM_STOPGROUPTYPING, fixed undo grouping (with tests)
Dylan Smith
dylan.ah.smith at gmail.com
Fri Jun 27 12:01:13 CDT 2008
Neither am I looking to work on EM_FORMATRANGE. I am trying to get my work
on tables to be in a more stable state, since richedit controls need to be
able to support nested paragraphs for the v4.1 implementation of tables
(i.e. a table row is a paragraph, and cells are a container of nested
paragraphs/table rows).
On Thu, Jun 26, 2008 at 10:35 PM, James McKenzie <jjmckenzie51 at sprintpcs.com>
wrote:
> Alex Villacís Lasso wrote:
>
>> Dylan Smith escribió:
>>
>>
>>> EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The
>>> remarks for this message on MSDN explains what events stops group
>>> typing, which led me to adding the delete key to the actions that stop
>>> group typing.
>>>
>>> The tests that are included with this patch verify the correctness of
>>> the changes.
>>>
>>> This patch depends on a previous patch I submitted, which has an email
>>> subject "[6/44] richedit: Implemented undo coalescing to group typing
>>> events", and was submitted on June 17.
>>> ---
>>> dlls/riched20/editor.c | 12 ++++++++++--
>>> dlls/riched20/tests/editor.c | 40
>>> ++++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 50 insertions(+), 2 deletions(-)
>>>
>>>
>> This patch has the corresponding test. Could you please send a patch (one
>> or more) that would test the behaviors fixed by the previous patches? This
>> will make it more likely for AJ to accept the patches, and will also prevent
>> someone (such as myself) from accidentally breaking fixed behavior with
>> further changes.
>>
>>
>>
> Alex:
>
> You are talking about fixing things. I was fixing EM_FONTRANGE before 1.0
> as it breaks several things. Are you looking to pick this up as one of the
> things you are going to fix?
>
> James McKenzie
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20080627/2aba6517/attachment.htm
More information about the wine-devel
mailing list