Coverity reported buffer overrun error in "winebuild: Add support for 16-bit exe modules."

Alexandre Julliard julliard at winehq.org
Sat Jun 28 11:29:23 CDT 2008


"Dan Kegel" <dank at kegel.com> writes:

> Coverity complains that
> http://source.winehq.org/git/wine.git/?a=commitdiff;h=0c214a7091af8efe39ffdaea7fe9e2de4d8006ba
> introduced a buffer overrun in winebuild.  It looks like
> somebody forgot to dynamically grow an array?
>
> Here's the report.  Can somebody familiar with the code (or
> with a little time on their hands) have a look?

The code is correct, spec->limit will always be 0 if there are no
exported entry points, so the loop where Coverity sees an overflow is
not actually executed.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list