(resend) msi: Fix bug in handling of multivolume CAB files.

[James Hawkins]

On Tue, Mar 4, 2008 at 7:01 PM, Ove Kaaven <ovek at transgaming.com> wrote:
> James Hawkins skrev:
>
> > A lot of time has been spent fixing cab/media related bugs in
>  > installers, as the behavior is very fickle (and easily breakable), so
>  > can you please add a test case first?  See the multicab tests that are
>  > already in install.c.  They will fail in wine because our cabinet.dll
>  > cannot create compressed cabinets, but assuming you test in Windows or
>  > use native cabinet.dll, it'll still verify that the patch is correct.
>
>  Using native cabinet.dll from XP causes numerous failures in those tests
>  (notably in caborder, if I remember right). I probably won't really have
>  time to track that down right now.
>
>  But it seems that I am able to use builtin cabinet if I change
>  create_cc_test_files to use a maxsize of 40000 or whatever instead of
>  200, so that it creates 2 cabfiles instead of 615. (That routine creates
>  something close to the situation I originally described, too.) And if I
>  try it that way, my patch seems to fix the todo tests at lines 1733 and
>  1734 (in test_uiLevelFlags), for some reason. Is that good enough?
>

The tests that now pass with native cabinet dll are test_continuouscab
(which is similar to what you're trying to test).  The point of
maxsize is so that it creates continuous cabs...there's no other way
to do it, and builtin doesn't create continuous cabs at all.  The
answer to your question is no, because there is no test currently that
runs down the code path you are fixing.

-- 
James Hawkins