[PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream

Vitaliy Margolen wine-devel at kievinfo.com
Tue May 13 14:42:53 CDT 2008


Eric Pouech wrote:
> @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, int len, HANDLE device) {
>          }
>  
>          /* Convert to OEM, then output */
> -        convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, message,
> +        convertedChars = WideCharToMultiByte(CP_UNIXCP, 0, message,
>                              len, output_bufA, MAX_WRITECONSOLE_SIZE,
>                              "?", &usedDefaultChar);
>          WriteFile(device, output_bufA, convertedChars,
> 
> 
This doesn't look right. What if it's wineconsole with user backend 
(default) and OEM CP (which is different then UNIXCP)? Should probably hack 
GetConsoleOutputCP() instead.

Vitaliy.



More information about the wine-devel mailing list