regressions running Photoshop?

Dan Kegel dank at kegel.com
Thu May 15 09:20:32 CDT 2008


On Thu, May 15, 2008 at 3:33 AM, Dmitry Timoshkov
<dmitry at codeweavers.com> wrote:
> The culprit is:
>
> 4046075462c00f4479f185d1c0514584ff851223 is first bad commit
> commit 4046075462c00f4479f185d1c0514584ff851223
> Author: Andrew Talbot <andrew.talbot at talbotville.com>
> Date:   Tue May 13 22:41:58 2008 +0100
>
>   cabinet: Remove order-of-evaluation dependencies.
>
> In particular the following change:
>
> -        n -= (e = (e = ZIPWSIZE - ((d &= ZIPWSIZE-1) > w ? d : w)) > n
> ?n:e);
> +        d = max(d & (ZIPWSIZE - 1), w);
> +        e = min(ZIPWSIZE - d, n);
> +        n -= e;
>
> I'll send a patch.

Thanks!  I feel bad - Susan had identified that as the culprit for
a Dragon Naturally Speaking regression, and I emailed the author
rather than the list.  Might have saved you an hour if I had sent it
to the list.
- Dan



More information about the wine-devel mailing list