Right way to cope with user error in make test?

Jeremy White jwhite at winehq.org
Fri May 16 10:49:37 CDT 2008


Hi Alistair,

> This could be a good option.  libxslt should properly be non-optional
> since msxml3 relys on it.
> 
> From the Makefile.in, its appears to have linked to libxslt for quite some 
> time,
> but was never an issue since it was never used.
> 
> Francois Gouget raised this bug,
> http://bugs.winehq.org/show_bug.cgi?id=13035
> that libslt should be dynamic, which could be another option.

I think in my case the problem is a bit different; I have the library -
what I don't have are the development headers.  Thus the linking all
works, but HAVE_LIBXSLT is not defined, so the transform function
ends up as a stub, and goes on to fail.

And I still don't know a right answer.

The attached patch is one approach - skip the tests in this case.

Does this seem like a reasonable approach to folks?

Cheers,

Jeremy


-------------- next part --------------
A non-text attachment was scrubbed...
Name: msxmltest.diff
Type: text/x-patch
Size: 681 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20080516/9ca4ff3d/attachment.bin 


More information about the wine-devel mailing list