user32: Allow a NULL foreground window in the tests

Dmitry Timoshkov dmitry at codeweavers.com
Thu May 29 20:24:31 CDT 2008


"James Hawkins" <truiken at gmail.com> wrote:

> Passing 0 for the foreground window essentially disables the test,
> whereas allowing a NULL window is testing another variation of what
> can happen with the foreground window, just like if a last error is,
> e.g.,  ERROR_FILE_NOT_FOUND on one platform instead of
> ERROR_PATH_NOT_FOUND.  Your method disables the test completely.

Yes, passing foreground == 0 disables the foreground window test. That
should be done very carefully for the tests that always fail. I'd expect
for instance test_SetActiveWindow() and test_SetForegroundWindow() not
need to disable it.

-- 
Dmitry.



More information about the wine-devel mailing list