Fixing crashes in Tests (OS version check)

Paul Vriens paul.vriens.wine at gmail.com
Sat May 31 05:12:31 CDT 2008


Alistair Leslie-Hughes wrote:
> Paul Vriens wrote:
>>
>>>
>> In this particular case you could make use of this fact:
>>
>> util.c:42:GetProcAddress(SnmpUtilAsnAnyCpy) failed
>> util.c:43:GetProcAddress(SnmpUtilAsnAnyFree) failed
>> util.c:44:GetProcAddress(SnmpUtilOctetsCmp) failed
>> util.c:45:GetProcAddress(SnmpUtilOctetsCpy) failed
>> util.c:46:GetProcAddress(SnmpUtilOctetsFree) failed
>> util.c:47:GetProcAddress(SnmpUtilOctetsNCmp) failed
>>
>> This happens to be true for win95, win95, winme and NT4.
>>
>> So if those functions are not available set a variable. Then use that 
>> variable to skip some tests that crash.
>>
> Hi Paul,
> 
> These functions aren't the issue, since they are worked out at runtime.
> 
> An example of one that fails is
> ret = SnmpUtilOidToA(NULL);
> Under win98, this function is valid to call, but will crash if you call 
> it will a NULL parameter.  I don't think removing this test a good idea, 
> since we are setting XP as a base, at this passes.
> 
> Best Regards
>  Alistair Leslie-Hughes
> 
> 
> 
> 
What I meant is that these non available functions are an indication for NT4 and 
below. This means you can detect by logic whether you are on NT4 (and below) or 
above. This logic can be used to skip some tests.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list