fix a crash in widl on Vista x86

Rob Shearman robertshearman at gmail.com
Tue Nov 18 08:36:23 CST 2008


2008/11/17  <netzimme at aim.com>:
> Changelog:
>  Add a FIXME for the crash in widl on Vista x86.
>
> diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
> index fcb141e..45467e5 100644
> --- a/tools/widl/typegen.c
> +++ b/tools/widl/typegen.c
> @@ -3137,7 +3137,7 @@ size_t get_size_procformatstring(const
> statement_list_t *stmts, type_pred_t pred
>             size += get_size_procformatstring(stmt->u.lib->stmts, pred) - 1;
>             continue;
>         }
> -        else if (stmt->type != STMT_TYPE && stmt->u.type->type !=
> RPC_FC_IP)
> +        else if (stmt->type != STMT_TYPE || stmt->u.type->type !=
> RPC_FC_IP)
>             continue;
>
>         iface = stmt->u.type;

Looks good. I had the same fix queued up in my tree. However, your
changelog message needs some work. The bug isn't specific to Vista
x86, but is probably specific to the IDL file you are compiling.

-- 
Rob Shearman



More information about the wine-devel mailing list